Open
Conversation
importModeManager.Close() restores subject modes concurrently via errgroup. Each goroutine calls setSubjectMode() which invokes the TestingOnSetSubjectMode callback. Serialize callback invocations with a dedicated mutex to prevent data races in test callbacks that write to shared state. Fixes CON-410
Pin the Kafka host port so it survives container stop/start and kill/start cycles. Without pinning, Docker assigns a new random port on restart, but the Redpanda config inside the container still advertises the old port, causing Kafka clients to reconnect to a dead address. Also replace fixed 2s sleep before chaos with require.Eventually that waits for both producer and consumer to confirm message flow, and add a TCP readiness check after every broker restart. Extend redpandatest.Config with ExtraOpts to allow passing additional testcontainers options, so the chaos tests reuse StartSingleBrokerWithConfig instead of duplicating container setup. Fixes CON-417
|
Commits Review LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits
Jira